[coreboot-gerrit] [XS] Change in coreboot[main]: payloads/external/Makefile.mk: Update linuxboot warning

[Elyes Haouas (Code Review)]

Attention is currently required from: Martin L Roth, Maximilian Brune.

Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85957?usp=email )

Change subject: payloads/external/Makefile.mk: Update linuxboot warning
......................................................................

Patch Set 1:

(1 comment)

File payloads/external/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/85957/comment/0687fd47_ea40b140?usp... :
PS1, Line 393: ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE),y)
             : ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE_PATH),"")
             :     # use coreboots cross toolchain
             :     CONFIG_LINUXBOOT_CROSS_COMPILE_PATH=$(CROSS_COMPILE_$(LINUXBOOT_CROSS_COMPILE_ARCH-y))
             : endif # CONFIG_LINUXBOOT_CROSS_COMPILE_PATH
             : else  # CONFIG_LINUXBOOT_CROSS_COMPILE
             : ifeq ($(CONFIG_PAYLOAD_LINUXBOOT),y)
             :     # only print warning when Linuxboot payload is actually selected
             :     $(warning "Using host toolchain to build Linuxboot")
             : endif # CONFIG_PAYLOAD_LINUXBOOT
             : endif # CONFIG_LINUXBOOT_CROSS_COMPILE
I'm not sure, but about this:

```suggestion
ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE),y)
    ifeq ($(strip $(CONFIG_LINUXBOOT_CROSS_COMPILE_PATH)),)
        # No custom toolchain specified, use the coreboot cross toolchain
        CONFIG_LINUXBOOT_CROSS_COMPILE_PATH := $(CROSS_COMPILE_$(LINUXBOOT_CROSS_COMPILE_ARCH))
    endif
else
    ifeq ($(CONFIG_PAYLOAD_LINUXBOOT),y)
        # Print a warning that we are using the host toolchain
        $(warning "Using host toolchain to build LinuxBoot")
    endif
endif
```