Attention is currently required from: Maximilian Brune, Angel Pons, Arthur Heymans, Lean Sheng Tan, David Milosevic.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 14:
(5 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164758): https://review.coreboot.org/c/coreboot/+/68137/comment/5e202ffe_8a0a9d36 PS14, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164758): https://review.coreboot.org/c/coreboot/+/68137/comment/093a5c6f_4addc744 PS14, Line 89: switch (access) { switch and case should be at the same indent
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164758): https://review.coreboot.org/c/coreboot/+/68137/comment/1c235902_23de8b62 PS14, Line 40: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164758): https://review.coreboot.org/c/coreboot/+/68137/comment/b8515ac9_fe0617c2 PS14, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164758): https://review.coreboot.org/c/coreboot/+/68137/comment/bd0b6a56_86222d2c PS14, Line 34: switch (vpd) { switch and case should be at the same indent