Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41235 )
Change subject: cannonlake: update processor power limits configuration
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41235/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kaisa/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41235/2/src/mainboard/google/hatch/...
PS2, Line 127: soc_conf
These are variously named soc_conf, soc_config, and soc_confg. […]
Sure.
https://review.coreboot.org/c/coreboot/+/41235/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41235/2/src/mainboard/google/hatch/...
PS2, Line 127: soc_config
compare with kaisa
Done. Updated this in related files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac6e6f81343fcd769619e9d7ac339430966834f6
Gerrit-Change-Number: 41235
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 15 May 2020 09:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment