Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42257 )
Change subject: soc/intel/*/acpi: Put braces around *else* branch
......................................................................
Patch Set 2:
(1 comment)
What to do? Add or remove braces?
https://review.coreboot.org/c/coreboot/+/42257/2/src/soc/intel/jasperlake/ac...
File src/soc/intel/jasperlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/42257/2/src/soc/intel/jasperlake/ac...
PS2, Line 293: gnvs->chromeos.vbt2 = google_ec_running_ro() ?
: ACTIVE_ECFW_RO : ACTIVE_ECFW_RW;
Well, it uses multiple lines, so using braces makes the code clearer (even if only slightly). […]
Raul, could catch, I didn’t see that. I’ll update the commit message.
PS: Patrick once proposed on the mailing list to require braces even around single line statements.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb4427f7ae9f7b99ba74f7e84aed6b8a901ca9fc
Gerrit-Change-Number: 42257
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 12 Jun 2020 11:40:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment