Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33253 )
Change subject: src/superio/aspeed/ast2400: Use new SuperIO acpigen ......................................................................
Patch Set 22:
(5 comments)
there is only one comment left that might be worth a thought; I'm not marking that as resolved so that the whole patch isn't marked with all comments resolved, so it doesn't get accidentally merged before the SIO SSDT generation patch.
https://review.coreboot.org/c/coreboot/+/33253/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33253/13//COMMIT_MSG@9 PS13, Line 9: Code
code
Done
https://review.coreboot.org/c/coreboot/+/33253/13//COMMIT_MSG@9 PS13, Line 9: Autogen
autogen
Done
https://review.coreboot.org/c/coreboot/+/33253/13//COMMIT_MSG@10 PS13, Line 10: Code
code
Done
https://review.coreboot.org/c/coreboot/+/33253/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33253/14//COMMIT_MSG@10 PS14, Line 10: the ACPI Code for the AST2400. This is WIP.
Use coreboot’s common Super I/O SSDT generator to generate the SSDT entries for the Super I/O.
Done
https://review.coreboot.org/c/coreboot/+/33253/14//COMMIT_MSG@12 PS14, Line 12: Has been tested w/ AST2400.
How? What entries are now in the SSDT table?
Done