Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32617 )
Change subject: mb/lenovo/*: Add support for VBOOT on 12MiB devices ......................................................................
Patch Set 3:
Patch Set 2:
Patch Set 2:
commit message says "8 MiB flash" here. Also, why not "a and b", like https://review.coreboot.org/c/coreboot/+/29816 tries to do?
I just copied the commit message.
Also, some hints on how to test would be great in order to get it tested :) thanks!
Enable CONFIG_VBOOT and CONFIG_H8_FN_KEY_AS_VBOOT_RECOVERY_SW on default config. It will boot RW_MAIN_A/RW_MAIN_B on regular boot and WP_RO if you hold Fn-Key on boot.
thanks. now the vboot-rwa.fmd filenames suggest "a only". shouldn't that be "vboot-rw-ab.fmd" or "vboot-rwab.fmd"? As a different board has "vboot-ro.fmd" already, I guess this should match the content...
* changed file name to vboot-rwab.fmd * Added missing Kconfig for default fmap