21 Oct
2020
21 Oct
'20
3:58 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: fix LCMID to be 0x01 for Jacuzzi followers ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46442/5/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/5/src/mainboard/google/kukui/... PS5, Line 173: Could you remove this blank line? Also it's nice to take the chance to fix the one before sku_id().
--
To view, visit https://review.coreboot.org/c/coreboot/+/46442
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b43b9153315ec65e9168c4e84ea844dff14d446
Gerrit-Change-Number: 46442
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 03:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment