Hello Kyösti Mälkki, Timothy Pearson, David Hendricks, build bot (Jenkins), Patrick Georgi, Martin Roth, Damien Zammit,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34395
to look at the new patch set (#2).
Change subject: sb/amd/sb800: Remove bit shift that does nothing ......................................................................
sb/amd/sb800: Remove bit shift that does nothing
This bit shift attempts to set bits 8 and 9 of the byte variable (counting from 0). However, as the name suggests, this variable is only 8 bits wide, so the shift does nothing. Reading section 7.5 of the AMD SB800-Series Southbridges Register Programming Requirements manual, bits 8 and 9 are already set by default, so we can remove the bit shift. (Alternatively, we could try setting the corresponding bits one byte higher in 0xF1 if needed.)
Change-Id: I645236441e02925ee01339378d213cb343027363 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1229582 --- M src/southbridge/amd/sb800/usb.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/34395/2