[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brya: Do not select HAVE_ACPI_RESUME

[Paul Menzel (Code Review)]

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro.

Paul Menzel has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86422?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: mb/google/brya: Do not select HAVE_ACPI_RESUME
......................................................................

Patch Set 1:

(5 comments)

Patchset:

PS1: 
Best would be to suppert ACPI S3 properly.

Commit Message:

https://review.coreboot.org/c/coreboot/+/86422/comment/0a0936d1_0c9e239a?usp... :
PS1, Line 9: Brya mainboard does not reliably support S3 entry/exit.
Why?

https://review.coreboot.org/c/coreboot/+/86422/comment/0a3a7bbc_25ca648d?usp... :
PS1, Line 9: no
not

https://review.coreboot.org/c/coreboot/+/86422/comment/5e0b20e3_cf33aabf?usp... :
PS1, Line 10: Also trigger a fail-safe board
            : reset if the system resumes from S3.
Please make this a separate commit. I also do not agree with this. What does this protect against? If a device owner wants to do ACPI S3 resume, not possible with the standard install, let them.

https://review.coreboot.org/c/coreboot/+/86422/comment/273deaeb_db56b6e8?usp... :
PS1, Line 15: asl
ASL