Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38779 )
Change subject: vboot: push clear recovery mode switch until BS_WRITE_TABLES ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38779/6/src/include/bootmode.h File src/include/bootmode.h:
https://review.coreboot.org/c/coreboot/+/38779/6/src/include/bootmode.h@24 PS6, Line 24: void clear_recovery_mode_switch(void *unused); It's kinda ugly to have the (void *) argument here, and I also realized that it would be nice to check for VB2_CONTEXT_FORCE_RECOVERY_MODE in the context before calling this (so that we avoid all that extra EC communication when we know there's nothing there to clear anyway). So maybe add a small stub function in bootmode.c to do that check and then call this without the unused argument?
https://review.coreboot.org/c/coreboot/+/38779/6/src/mainboard/intel/kblrvp/... File src/mainboard/intel/kblrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38779/6/src/mainboard/intel/kblrvp/... PS6, Line 64: You forgot to update the Kconfig for this one?