build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: Support DDR frequency 3600Mbps ......................................................................
Patch Set 9:
(19 comments)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/dra... PS9, Line 68: if (freq_group == LP4X_DDR1600) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/dra... PS9, Line 87: (0x0 << 31) | (0x0 << 30) | (0x6 << 20) | (0x9 << 16 ) | space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/dra... PS9, Line 96: (0x1 << 31) | (0x1 << 30) | (0x7 << 20 ) | (0x7 << 16 ) | space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/dra... PS9, Line 1853: clrsetbits_le32(&ch[chn].ao.padctrl, 0x3 | 0x1 << 3 , space prohibited before that ',' (ctx:WxE)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/dra... PS9, Line 1933: (0xf << 28) |(0xf << 20) | (0xf << 24) | 0xf, need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 23: <<<<<<< HEAD spaces required around that '<' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 24: ======= spaces required around that '==' (ctx:ExO)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 24: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 24: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 24: ======= spaces required around that '=' (ctx:OxE)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 27: >>>>>>> 68cd2f807b... mediatek/mt8183: Support DDR frequency 3600Mbps spaces required around that '>' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 27: >>>>>>> 68cd2f807b... mediatek/mt8183: Support DDR frequency 3600Mbps spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 340: <<<<<<< HEAD spaces required around that '<' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 341: ======= spaces required around that '==' (ctx:ExO)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 341: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 341: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 341: ======= spaces required around that '=' (ctx:OxE)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 365: >>>>>>> 68cd2f807b... mediatek/mt8183: Support DDR frequency 3600Mbps spaces required around that '>' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/34332/9/src/soc/mediatek/mt8183/emi... PS9, Line 365: >>>>>>> 68cd2f807b... mediatek/mt8183: Support DDR frequency 3600Mbps spaces required around that ':' (ctx:VxW)