Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45889 )
Change subject: mb/google/volteer: Expand WP_RO region to 8MB in fmap ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45889/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/45889/2/src/mainboard/google/voltee... PS2, Line 9: # SPI flash only the top 16MiB actually gets memory mapped.
I think it might be really difficult given the size of CSME RW binary.
I mean, honestly, if you don't think you can free this space up without taking on real post-ship risks for the platform, then don't do it. Image quality is nice to have but it shouldn't lead to a situation where we can one day not ship an important RW update because it won't fit. The 1200x675 resolution is still "okay", it is readable, it won't be the prettiest Chromebook but it will serve its function. (We are working on changing the bmpblk configuration file so rather than specifying a target resolution, you'd just specify a "quality level", and then this difference wouldn't look so bad anymore. It is not realistic and was never the plan that we would ship native resolution images in flash for a ridiculously hi-res panel like yours. What matters is the optical effect to the user, and that's roughly the same when upscaling a 720p asset to a 1080p or a 4K panel, as long as both of those panels are 13".)