Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/27228
Change subject: smm: Switch from %edx to %ebx ......................................................................
smm: Switch from %edx to %ebx
%edx gets clobbered before the c handler is invoked. This is just a cleanup cl to make the next cl look clean.
BUG=b:80539294 TEST=verified SMI still works on grunt.
Change-Id: I21bf41ed4fdeaaa8737c883f202a39cb57c2b517 Signed-off-by: Raul E Rangel rrangel@chromium.org --- M src/cpu/x86/smm/smm_stub.S 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/27228/1
diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S index 3fea32c..060361b 100644 --- a/src/cpu/x86/smm/smm_stub.S +++ b/src/cpu/x86/smm/smm_stub.S @@ -132,9 +132,9 @@ 1: movl stack_size, %eax mul %ecx # %eax(stack_size) * %ecx(cpu) = %eax(offset) - movl stack_top, %edx - subl %eax, %edx # %edx(stack_top) - %eax(offset) = %edx(stack_top) - mov %edx, %esp + movl stack_top, %ebx + subl %eax, %ebx # %ebx(stack_top) - %eax(offset) = %ebx(stack_top) + mov %ebx, %esp
pushl $0x0 # push a NULL stack base pointer mov %esp, %ebp