Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32992 )
Change subject: soc/intel/cannonlake: Add ability to disable Heci1
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/32992/10/src/soc/intel/cannonlake/fsp_params...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/32992/10/src/soc/intel/cannonlake/fsp_params...
PS10, Line 344: Disabled
Just wanted to point out how this option is "negative" compared to everything around it. […]
I have been told changing this is not trivial, so please disregard. Sorry for the noise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c63316c8b04fb101d34064daac5ba4fdc05a63c
Gerrit-Change-Number: 32992
Gerrit-PatchSet: 10
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:46:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment