build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 3:
(73 comments)
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c@... PS3, Line 582: printf (" filename=%s\n", index->filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c@... PS3, Line 592: printf (" filename=%s\n", index->filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c@... PS3, Line 977: static const char *optstring = "x:i:g:AMS:p:b:s:r:k:c:n:d:t:u:w:m:T:z:J:B:K:L:Y:N:UW:I:a:Q:V:e:v:j:y:G:O:X:F:H:o:f:l:hZ:qR:P:C"; line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c@... PS3, Line 1095: config_file = malloc (fd_stat.st_size+1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c@... PS3, Line 1404: if (configfd >=0) { spaces required around that '>=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c@... PS3, Line 1404: if (configfd >=0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/amdfwtool.c@... PS3, Line 1414: close (configfd); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 11: "(^[[:space:]]*$)" "|" /* or ... */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 11: "(^[[:space:]]*$)" "|" /* or ... */ Consecutive strings are generally better as a single string
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 13: "(^[[:space:]]*" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 15: "#.*$)"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 20: "^[[:space:]]*" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 22: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 24: "[[:space:]]+" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 26: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 28: "[[:space:]]*$"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 33: "^[[:space:]]*" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 35: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 37: "[[:space:]]+" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 39: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 41: "[[:space:]]+" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 43: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 45: "[[:space:]]*$"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 54: if ((result = regcomp(reg, expr, cflags)) != 0) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 75: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 84: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 93: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 101: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 108: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 115: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 122: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 129: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 136: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 143: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 150: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 157: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 164: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 171: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 178: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 186: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 193: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 202: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 209: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 216: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 223: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 230: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 237: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 244: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 251: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 259: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 266: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 273: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 281: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 288: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 295: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 303: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 310: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 322: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 330: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 338: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 350: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 400: tableptr += sizeof (amd_bios_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 404: if (strcmp(fw_name, "PSP_SOFTFUSE") == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 414: ((amd_fw_entry *)tableptr)->other = strtoull(filename, NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 417: tableptr += sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 430: if (*ptr == '\0') return -1; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 433: while (*ptr != '\n' && *ptr != '\0') { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 434: ptr ++; space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 440: memcpy (*oneline, line_start, num); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 442: ptr ++; /* skip enter. */ space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 453: compile_reg_expr(REG_EXTENDED | REG_NEWLINE, blank_or_comment_regex, &blank_or_comment_expr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 455: compile_reg_expr(REG_EXTENDED | REG_NEWLINE, entries_subprog_line_regex, &entries_subprog_line_expr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/3/util/amdfwtool/data_parse.c... PS3, Line 462: if (!regexec(&blank_or_comment_expr, oneline, 0, NULL, 0)){ space required before the open brace '{'