[coreboot-gerrit] Change in coreboot[master]: soc/intel: apl,skl,cnl,icl: implement a PRMRR size selection algorithm

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35902 )

Change subject: soc/intel: apl,skl,cnl,icl: implement a PRMRR size selection algorithm
......................................................................

Patch Set 13:

(2 comments)

This change is ready for review.

https://review.coreboot.org/c/coreboot/+/35902/13/src/soc/intel/common/block... 
File src/soc/intel/common/block/cpu/cpulib.c:

https://review.coreboot.org/c/coreboot/+/35902/13/src/soc/intel/common/block... 
PS13, Line 345: 		die("Unsupported PRMRR size limit %i MiB, check your config!\n", limit);
What if PRMRR isn't supported at all? What does this MSR read back? I'm curious if this MSR always returns values that are non-zero. If not, we'll die() here.

https://review.coreboot.org/c/coreboot/+/35902/13/src/soc/intel/common/block... 
File src/soc/intel/common/block/include/intelblocks/cpulib.h:

https://review.coreboot.org/c/coreboot/+/35902/13/src/soc/intel/common/block... 
PS13, Line 165: /* Get the maximum valid PRMRR size with respect to the specified limits */
Indicate the units returned. Code inspection seems to indicate 'size in bytes'.