Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41392 )
Change subject: libpayload/cbgfx: Remove gap between adjacent boxes ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... PS1, Line 82: while (d > INT32_MAX || d < INT32_MIN) {
log2 and MAX(n, d)
Done.
About the right shifting, if (x < 0), then the most significant bit of (x >> shift) seems to be implementation-defined [1].
[1] https://www.gnu.org/software/gnu-c-manual/gnu-c-manual.html#Bit-Shifting
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... PS1, Line 233: int draw_box(const struct rect *box, const struct rgb_color *rgb)
off-topic, but I think we should try to get rid of this and just only use draw_rounded_box() everywh […]
Yeah, I agree.