Attention is currently required from: Julius Werner.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82933?usp=email )
Change subject: soc/nvidia/tegra210/ccplex.c: Remove unused macro
......................................................................
Patch Set 4:
(1 comment)
File src/soc/nvidia/tegra124/spi.c:
https://review.coreboot.org/c/coreboot/+/82933/comment/25858060_7911435a?usp... :
PS1, Line 42: #define SPI_CMD1_MODE_SHIFT 28
Why are you doing this? It is standard when writing drivers to define accessor macros for all regist […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82933?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b1a400e8ce6688c2eeb5c815b7409a53241fc77
Gerrit-Change-Number: 82933
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 06 Jun 2024 19:58:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org