Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33205 )
Change subject: soc/intel/braswell: Use sb/intel/common/spi.c
......................................................................
Patch Set 20: Code-Review+1
Same as with Broadwell, I guess we could get rid of a
lot of defines in a header file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I540f73514f17d3b135c3222facfe23170d2bb0c8
Gerrit-Change-Number: 33205
Gerrit-PatchSet: 20
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 09 Nov 2019 23:23:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment