Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7 ......................................................................
Patch Set 13:
(8 comments)
These changes make your mainboard using the variant mechanism, but I suggest you get the other changes done first.
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/Kconfig:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 18: Add this config DEVICETREE string default "variant/$(VARIANT_DIR)/devicetree.cb"
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 26: Add this config VARIANT_DIR string default "ga-z170x-gaming7" if BOARD_GIGABYTE_GA_Z170X_GAMING_7
and create this directory variant/ga-z170x-gaming7
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 18: hda_verb.c Replace with .. variant/$(VARIANT_DIR)/hda_verb.c
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 19: gma-mainboard.ads Replace with .. variant/$(VARIANT_DIR)/gma-mainboard.ads
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
PS13: Move this file to variant/ga-z170x-gaming7
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
PS13: Move this file to variant/ga-z170x-gaming7
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/gpio.c:
PS13: Move this file to variant/ga-z170x-gaming7
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/hda_verb.c:
PS13: Move this file to variant/ga-z170x-gaming7