Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35482 )
Change subject: superio/nuvoton/nct5104d: Add soft reset GPIO functionality ......................................................................
Patch Set 3: Code-Review+2
I can't say that I'm completely 100% happy with this, but since setting the pin state to input is a safe default, I have no strong objections to this patch. I just hope that this won't cause someone else to spent too much time on figuring out why this might do something that they don't necessarily expect. In that case this can be mad configurable by an option in the chip.h file of this SIO (not sure if it exists for this specific chip, but for others it does exist) and enabled via a devicetree setting for the boards that want/need this functionality. If you want, you could add that as a patch on top of this patch train, so that the boards can explicitly enable this behaviour.