Change subject: soc/intel/common/cpu: Update COS mask calculation for NEM enhanced mode
......................................................................
Patch Set 4:
Patch Set 4:
Aamir, have you had a chance to test on other chipsets besides TGL ?
I was able to boot up the JSL SoC with this change. I am yet to verify the mask contents in MSR.
Did you also enable COS_MAPPED_TO_MSB and USE_CAR_NEM_ENHANCED_V1 in your mainboard Kconfig?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54e047161853bfc70516c1d607aa479e68836d04
Gerrit-Change-Number: 43494
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Comment-Date: Tue, 01 Sep 2020 22:47:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment