12 May
2020
12 May
'20
5:46 p.m.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41272 )
Change subject: soc/amd/common/block: Add support for configuring eSPI connection to slave ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41272/2/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/41272/2/src/soc/amd/common/block/lp... PS2, Line 763: enabled When we get verstage in PSP enabled, it could setup the other channels as well. So the initial state is unknown. So maybe we should update the rest of the functions to explicitly disable the channel?
--
To view, visit https://review.coreboot.org/c/coreboot/+/41272
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I872ec09cd92e9bb53f22e38d2773f3491355279e
Gerrit-Change-Number: 41272
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Eric Peers epeers@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 May 2020 17:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment