Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47158 )
Change subject: mb/google/zork: update berknip CHTC thermal setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47158/2/src/mainboard/google/zork/v...
PS2, Line 9: register "system_config" = "3"
This still looks wrong to me. […]
Yes, That should set "2" for TDP 15w and "3" for 25w. and since it also set the sustained_power_limit to 12w so it will be limited. Checking with IRM, the difference between "2" and "3" is only the sustained_power_limit. but suggest setting the system_config to "2" to
prevent potential risk.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03245a824d838c2d9468ae0fa3cfa34389560e9d
Gerrit-Change-Number: 47158
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 04:58:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Peers
epeers@google.com
Gerrit-MessageType: comment