Attention is currently required from: Jakub Czapiga, Paul Fagerburg, Julius Werner. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54072 )
Change subject: tests: code coverage improvements ......................................................................
Patch Set 1:
(3 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54072/comment/b173c287_329b1959 PS1, Line 180: ifeq ($(COV),1)
I *think* that you should set COV to 1 if coverage-report-tests is present in the $(MAKECMDGOALS). […]
So there are two options, the one I outlined below, or setting COV=1 if MAKECMDGOALS contains coverage-report-tests (while never resetting it) _really early_ (so the different default path in line 8 takes effect). Both are fine, but just printing a message (and not even returning failure) bypasses the intended work too easily.
https://review.coreboot.org/c/coreboot/+/54072/comment/99222288_d331046b PS1, Line 181: coverage-report-tests:
clean-coverage-report-tests target might be useful. It may be an alias for clean-unit-tests.
Not a huge fan of using make targets for all kinds of batch processing, but given how we do that for all kinds of things, I suppose it makes sense...
https://review.coreboot.org/c/coreboot/+/54072/comment/c2dc3daf_647ae06a PS1, Line 187: @echo Please use COV=1 when creating code coverage reports. simplest solution could be calling `$(MAKE) coverage-report-tests COV=1` here, no?