Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb: add new board clevo/tgl-u/l140mu ......................................................................
Patch Set 9:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59548/comment/966bdee7_7ef69149 PS8, Line 12: - On-board RAM and DIMM slot
If you have the model numbers at hand, that’d be great to have documented.
Ack
https://review.coreboot.org/c/coreboot/+/59548/comment/6af14de9_94046f9a PS8, Line 25: I couldn't test anything more due to security policy
Dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/59548/comment/4e93461a_f3799aeb PS8, Line 26: TianoCore
The one from Kconfig, that means MrChromebox’ version?
yes, Kconfig default
https://review.coreboot.org/c/coreboot/+/59548/comment/fe00c43d_63e94615 PS8, Line 27:
How did you figure out the GPIOs? inteltool?
Ack
https://review.coreboot.org/c/coreboot/+/59548/comment/0bf7fedf_c94113a9 PS8, Line 48: - TPM interrupt on Linux [1]
Probably that took a large chunk of time to figure out. […]
It took me two evenings \o/ In the end I've been debugging in uefishell manually configuring and sending commands via `mm` to find out if the GPIO works at all. Since Linux' tpm_tis driver is a mess, it took some time to find out what's going wrong there...
The main problems are: - locality request missing, thus global INT_EN never gets set - interrupt test could *never* work bc it's simply broken and obviously was never tested before committing
https://review.coreboot.org/c/coreboot/+/59548/comment/7ffdec8e_478870a3 PS8, Line 56:
It’d be great, if you also added, if flashrom’s internal programmer works with the vendor firmware, […]
Ack