Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40538 )
Change subject: tests: Add lib/string-test test case ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40538/1/tests/include/mocks/assert.... File tests/include/mocks/assert.h:
https://review.coreboot.org/c/coreboot/+/40538/1/tests/include/mocks/assert.... PS1, Line 21: Fix vendorcode headers vendorcode is code that we tend not to touch because it comes from the outside (although we lifted that restriction for amd agesa given that it isn't updated anymore), so I guess better isolation is the way to go.
https://review.coreboot.org/c/coreboot/+/40538/1/tests/lib/string-test.c File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/40538/1/tests/lib/string-test.c@22 PS1, Line 22: strlen how can we ensure that we're not just testing libc's implementation here?