[coreboot-gerrit] Change in coreboot[master]: [WIP] drivers/intel/fsp2_0: Add FSP 2.3 support

[Anil Kumar K (Code Review)]

Attention is currently required from: Subrata Banik, Paul Menzel, Werner Zeh, Andrey Petrov, Patrick Rudolph.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59324 )

Change subject: [WIP] drivers/intel/fsp2_0: Add FSP 2.3 support
......................................................................

Patch Set 17:

(3 comments)

File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/59324/comment/19f0cd5b_4f297c6f 
PS14, Line 38:   Features added into FSP 2.3 specification that impact coreboot are:
             : 	  1. FSP_INFO_HEADER changes
             : 	    Updated SpecVersion from 0x22 to 0x23
             : 	    Updated HeaderRevision from 5 to 6
             : 	    Added ExtendedImageRevision
             : 	    FSP_INFO_HEADER length changed to 0x50
             : 	  2. Added FSP_NON_VOLATILE_STORAGE_HOB2
> I am not sure that this is a helpful text in the Kconfig menu. […]

I cut short the Kconfig description and added the details in commit message

File src/drivers/intel/fsp2_0/header_display.c:

https://review.coreboot.org/c/coreboot/+/59324/comment/2796e5e2_3a8522fb 
PS14, Line 11: externded
> extended

Ack

https://review.coreboot.org/c/coreboot/+/59324/comment/44ef4196_f7bd9c53 
PS14, Line 22: 		((ext_revision.rev.revision << 8) | revision.rev.revision),
             : 			((ext_revision.rev.bld_num << 8) | revision.rev.bld_num));
> You fill in the extended revision number only if FSP2. […]

Hi Werner. As per previous comment from Subrata, the local variable is initialized to zero.