Attention is currently required from: Subrata Banik, Paul Menzel, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 )
Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS
......................................................................
Patch Set 10:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69639/comment/9ac39119_d6560944
PS9, Line 9: Update location of TGP (MAGA) to Params2[15:0]
: Add TPPA (value of 25W)
Please format this as a list.
Done
https://review.coreboot.org/c/coreboot/+/69639/comment/54edd425_855cea79
PS9, Line 13: .
: .
: .
Why the three lines?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f
Gerrit-Change-Number: 69639
Gerrit-PatchSet: 10
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 15:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment