[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44632 )

Change subject: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support
......................................................................

Patch Set 4: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/44632/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/eldrid/memory.c:

https://review.coreboot.org/c/coreboot/+/44632/4/src/mainboard/google/voltee... 
PS4, Line 7: static const struct mb_ddr4_cfg eldrid_memcfg = {
Please add a comment here that states "This mb_ddr4_cfg structure is intentially left empty so that fields are left nil. 0 on the UPD means let MRC auto configure. e do not need to set any Rcomp values, MRC will auto configure them."

https://review.coreboot.org/c/coreboot/+/44632/4/src/mainboard/google/voltee... 
PS4, Line 8: };
This also indirectly sets ECT to 0, which will not disable early command training.
If that's not what you want, you will need to initialize .ect to 1 here.