Pavlushka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 82:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 204: device pnp 2e.ff on # passes SIO base addr to SSDT gen
Indent with an extra tab
Done
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 205: chip superio/nuvoton/nct5539d
Two extra tabs
Done
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 206: device pnp 2e.2 on # UART A
Three extra tabs
Done
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 244: end # superio/nuvoton/nct5539d
Two tabs
Done
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 245: end # SSDT gen
One tab
Done
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 4: * Copyright (C) 2019 Pavel Sayekat pavelsayekat@gmail.com
move to AUTHORS and add SPDX header; same for all other files
Done