Attention is currently required from: Bora Guvendik, Furquan Shaikh, Selma Bensaid, Tim Wawrzynczak, Julius Werner, Angel Pons, Aaron Durbin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51445 )
Change subject: timestamp: Add new helper functions ......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51445/comment/e8485632_a3c0b8dd PS3, Line 7: Add helper fucntions
Julius, please see the following 2 patches, I implemented your suggestion (hope understood correctly). https://review.coreboot.org/c/coreboot/+/59554/1 https://review.coreboot.org/c/coreboot/+/59555/2
I think it ended up being more complicated than this rewind api.
0:1st timestamp 0 944:CSE sent 'Boot Stall Done' to PMC 296,000 945:CSE started to handle ICC configuration 303,000 (7,000) 946:CSE sent 'Host BIOS Prep Done' to PMC 308,000 (5,000) 947:CSE received 'CPU Reset Done Ack sent' from PMC 1,074,000 (766,000) 11:start of bootblock 1,101,606 (27,606) 12:end of bootblock 1,161,989 (60,382)
I had to qsort a second time because below is what it looks like after the initial qsort, the largest negative shows up first.
Yes, this is what I thought too while commenting because it will consider higher negative value as least timestamp entry.
0:1st timestamp 0 947:CSE received 'CPU Reset Done Ack sent' from PMC 1,074,000 946:CSE sent 'Host BIOS Prep Done' to PMC 308,000 (18,483,711,495,936,957) 945:CSE started to handle ICC configuration 303,000 (18,483,711,496,697,957) 944:CSE sent 'Boot Stall Done' to PMC 296,000 (18,483,711,496,695,957) 11:start of bootblock 1,101,606 (805,606) 12:end of bootblock 1,161,989 (60,382)