Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu.
Robert Chen has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Update ext_vr for board version > b ......................................................................
Patch Set 14:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84953/comment/e85d47cd_7967a6e4?usp... : PS11, Line 7: mb/google/dedede/var/drawcia: Correct board version in variant_devicetree_update
Keep this line to less than 70 characters. May be: […]
Done
https://review.coreboot.org/c/coreboot/+/84953/comment/d70060fc_e55362d8?usp... : PS11, Line 11: more board added after that. Specific Drawper board version as 0xa, 0xb and 0xf.
`Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Done
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/84953/comment/d2cee444_01c5b67f?usp... : PS11, Line 37: /* Remove power IC after board version 0xc */
Please move this comment above the if condition. […]
Done
https://review.coreboot.org/c/coreboot/+/84953/comment/dd545d66_4b0de53e?usp... : PS11, Line 42: /* board version 0xa, 0xb , 0xf is for drawper unit */
Please move this comment above the if condition. […]
Done