Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44135 )
Change subject: mb/google/zork: keep the c-state IO base address alignment
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44135/4/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/44135/4/src/soc/amd/picasso/Kconfig...
PS4, Line 260: PICASSO_CSTATE_IO_BASE_ADDR
Does this need to be in the I/O range specified by CONFIG_PICASSO_ACPI_IO_BASE? If so, this should p […]
I suspect this is just a trap address, but it doesn't hurt to make it an offset.
https://review.coreboot.org/c/coreboot/+/44135/5/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/44135/5/src/soc/amd/picasso/include...
PS5, Line 66: 0x413
I think Felix wanted this to be the offset from PICASSO_ACPI_IO_BASE: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98d34af518439d338326446c20601867ad31690
Gerrit-Change-Number: 44135
Gerrit-PatchSet: 6
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 14:45:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment