[coreboot-gerrit] [S] Change in coreboot[main]: soc/amd/common: Support sbin ucode files

[Maximilian Brune (Code Review)]

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, Patrick Rudolph, Raul Rangel.

Maximilian Brune has posted comments on this change by Fred Reitberger. ( https://review.coreboot.org/c/coreboot/+/68122?usp=email )

Change subject: soc/amd/common: Support sbin ucode files
......................................................................

Patch Set 7:

(2 comments)

This change is ready for review.

File src/soc/amd/common/block/cpu/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/68122/comment/83344af2_c4c49bcf?usp... :
PS5, Line 20: ucode
> Why add ucode.sh here? It's only like 5 lines of code. […]

This kind of shell code (if else stuff) is arguable harder to read if directly included inside the Makefile. I get your point though. In patchset 7 I put it directly into the recipe. Let me know what you prefer.

https://review.coreboot.org/c/coreboot/+/68122/comment/61ada4b0_147016e7?usp... :
PS5, Line 41: $(amd_microcode_bins)
> You can add all patch files to `amd_microcode_bins` and then filter them: […]

Doesn't that make it unnecessarily complicated? We would still need 2 loops to filter sbin and bin. We might as well separate them from the start.