13 Feb
2021
13 Feb
'21
12:29 p.m.
Attention is currently required from: Angel Pons. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40370 )
Change subject: nb/i945/raminit: Simplify if statement blocks ......................................................................
Patch Set 5:
(1 comment)
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/40370/comment/44abaa1f_88c44766 PS3, Line 2174: /* FIXME bits 5 and 0 only if PCIe graphics is disabled */
why will this break something???? […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/40370
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c9e848077cdd13158dbfd19326b95b42fc1c1fb
Gerrit-Change-Number: 40370
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 13 Feb 2021 11:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr
Gerrit-MessageType: comment