Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: Load calibration params and run DRAM calibration flow ......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35110/19/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/19/src/mainboard/google/kukui... PS19, Line 100: struct sdram_params *dst
https://review.coreboot.org/c/coreboot/+/35110/19/src/mainboard/google/kukui... PS19, Line 107: if (read_calibration_data_from_flash(freq_params) && : have_calibration_params(freq_params)) { : printk(BIOS_ERR, "have dram calibraion params\n"); : mt_mem_init(freq_params); : return; : } else { : int err = dram_blob_load_and_run(freq_params); : if (err == 0) { : printk(BIOS_INFO, "successfully load dram_blob and " : "run DRAM calibration\n"); : : write_calibration_data_to_flash(freq_params); : return; : } : printk(BIOS_ERR, "dram_blob load fail with error %d\n", err); : } : : /* init params setting from sdram configs if no have dram calibraion result */ : init_sdram_params(freq_params, get_sdram_config()); : mt_mem_init(freq_params); if (!read..() || !have...()) { /* Try to re-run full-calibration if available. */ int err = dram_run_full_calibration(); if (err == 0) { printk... write_calibration... return; } printk('failed to do full calibration (%d), fall back to default parameters.'); init_sdram_params(...); }
mt_mem_init(freq_params);