Attention is currently required from: Maxim.
Nico Huber has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/42914?usp=email )
Change subject: soc/intel/common/gpio_defs: Add macros for bidirectional pad
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16:
I still believe we shouldn't use inexplicable vendor values as a
role model for coreboot. If I don't miss anything, with these
settings one could read back the exact value written. That's all
isn't it? If we don't have any software that does that (why would
it?), why make our GPIO configs less transparent?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42914?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7b65f4da7616f2eefcd33a728d4d3ae5a79b014e
Gerrit-Change-Number: 42914
Gerrit-PatchSet: 16
Gerrit-Owner: Maxim
max.senia.poliak@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maxim
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 09:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No