Attention is currently required from: Cliff Huang, Intel coreboot Reviewers.
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/87085?usp=email )
Change subject: drivers/intel/touch: Conditionally add ACPI _PRW based on wake source
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/drivers/intel/touch/touch.c:
https://review.coreboot.org/c/coreboot/+/87085/comment/d0c47343_7cf931ab?usp... :
PS1, Line 197: /* NOTE: config->wake_gpio: uses GpioInt() in _CRS; PAD needs to be Driver Mode
Missing line break before NOTE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87085?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56fc8486c7494ff37c1d580d57838fee286128a6
Gerrit-Change-Number: 87085
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Comment-Date: Tue, 01 Apr 2025 21:30:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes