Attention is currently required from: Nico Huber, Maulik V Vaghela, Tim Wawrzynczak, Sugnan Prabhu S, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59124 )
Change subject: soc/intel/common: Add CPU related APIs ......................................................................
Patch Set 3:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59124/comment/d128a79c_60f8dde8 PS1, Line 12: Verified on Brya
can you please complete the sentence ?
Done
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/59124/comment/d8148d3e_b760a904 PS1, Line 277:
Add a help text ? […]
Done
https://review.coreboot.org/c/coreboot/+/59124/comment/5d536c81_e1f8dfa1 PS1, Line 192: res
may be ? […] Does it return supported (read: 1) on every core b/c the package supports hybrid cores?
Correct, it returns 1 on every E-core and P-core the package supports hybrid cores.
https://review.coreboot.org/c/coreboot/+/59124/comment/ca4de6be_3f24e47f PS1, Line 194: 7
can you please use a macro ?
Done
https://review.coreboot.org/c/coreboot/+/59124/comment/ccc3ac25_13762d2c PS1, Line 195: BIT(15)
can you please use a meaningful macro for this ?
Done
File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/59124/comment/9f0348ae_b51e8e34 PS1, Line 15: unsigned int
uint32_t ?
Done
https://review.coreboot.org/c/coreboot/+/59124/comment/d0adc4a3_7586df2d PS1, Line 21: int
bool ?
Done
https://review.coreboot.org/c/coreboot/+/59124/comment/e88e87d1_bd25a037 PS1, Line 144:
Remove unnecessary line
Done