Attention is currently required from: Martin Roth, Hsuan-ting Chen, Julius Werner.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60236 )
Change subject: util/futility: Ensure futility checks for flashrom as a dep
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
Patchset:
PS3:
I don't think this is the right approach, because the `tools` target is pretty must only used by Jen […]
You are probably right Julius, I was just looking for a intermediate step as futility needs quite a bit of work. I suppose i'll just knuckle down today and push though more futility refactoring.
File util/futility/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60236/comment/595d830c_60f80e0c
PS1, Line 7: |
There should be no veritical bar here? […]
.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d
Gerrit-Change-Number: 60236
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 20 Dec 2021 23:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment