Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35240 )
Change subject: drivers/spi/spi_flash.c: Add SPI vendor IDs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35240/2/src/include/spi-generic.h
File src/include/spi-generic.h:
https://review.coreboot.org/c/coreboot/+/35240/2/src/include/spi-generic.h@3...
PS2, Line 32:
I could do without the blank line, and match the style in the rest of the file. (Line 45 heads a whole bunch of definitions, so it doesn't count.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie39485d8c092151db8c9d88afaf02e19c507c93f
Gerrit-Change-Number: 35240
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Sep 2019 00:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment