22 Oct
2019
22 Oct
'19
2:27 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35967 )
Change subject: mb/google/poppy/variant/nocturne: don't invert GPP_D17 ......................................................................
Patch Set 1: Code-Review+2
Nick has been trying out some experiments, but +2 in case this seems absolutely necessary. For debug we should check ITSS polarities before and after FSP runs to ensure that it is not getting messed up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1408ef6ea92f6b31a9f3eee8720954af3a7c382
Gerrit-Change-Number: 35967
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org
Gerrit-Reviewer: Gwendal Grignou gwendal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Yicheng Li yichengli@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Yicheng Li yichengli@google.com
Gerrit-Comment-Date: Tue, 22 Oct 2019 21:27:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment