Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34571 )
Change subject: device/pci_rom: Add Option to force running the OptionROM ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
I don't see why we would need yet another Kconfig option for this. Please make use of/enhance the existing mechanisms instead. Let me know if you need further pointers for map_oprom_vendev().
https://review.coreboot.org/c/coreboot/+/34571/3/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/34571/3/src/device/pci_rom.c@105 PS3, Line 105: vendev == mapped_vendev coreboot already has a mechanism to handle an id mismatch: The driver for the integrated graphics device should map any compatible id to a default one (by implementing map_oprom_ vendev()). And the Kconfig default for VGA_BIOS_ID should reflect that id.
If such mapping happened `vendev == mapped_vendev` would be false and we'd already ignore the mismatch.