12 Oct
2020
12 Oct
'20
5:53 a.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46252 )
Change subject: mb/purism/librem_skl: Clean up FSP-M RCOMP settings ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46252/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/romstage.c:
https://review.coreboot.org/c/coreboot/+/46252/1/src/mainboard/purism/librem... PS1, Line 15: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig;
Jenkins, you're drunk.
shouldn't it be `const FSP_M_CONFIG *mem_cfg` ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/46252
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82b0997846d4ec40cf9b1a8ebfb1e881b194e078
Gerrit-Change-Number: 46252
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Oct 2020 02:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment