build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35410 )
Change subject: arch/arm: Implement FIT support
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35410/4/src/arch/arm/fit_payload.c
File src/arch/arm/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/35410/4/src/arch/arm/fit_payload.c@...
PS4, Line 41: u32 endianess;
'endianess' may be misspelled - perhaps 'endianness'?
https://review.coreboot.org/c/coreboot/+/35410/4/src/arch/arm/fit_payload.c@...
PS4, Line 53: if (hdr->magic == ZIMAGE_MAGIC) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifae3cbae85bcd1c35f31278f76f4d97700979da3
Gerrit-Change-Number: 35410
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 10 May 2020 14:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment