Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32532 )
Change subject: security/vboot/vboot_crtm.h: Remove ENV_ for vboot_measure_cbfs_hook() ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 5: Code-Review+2
LGTM but I think you need to rebase to get Jenkins to re-test this.
Did rebase, but got error on Google Aleena 'undefined reference to `vboot_measure_cbfs_hook' Will check.
The error 'undefined vboot_measure_cbfs_hook' will occur when both VBOOT and VBOOT_MEASURED_BOOT configs are enabled. The function definition of vboot_measure_cbfs_hook() is enabled, but the voot_ctrm.c is not included in bootblock. (I did a quick test adding vboot_crtm.c for bootblock, but this result in new build errors missing support in bootblock)
It is possible to check which .config is used by JENKINS for patch set 5?
I suggest revert to patch set 1? (adding _ENV to .c file) This will solve the original build issue and having a working JENKINS.