Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41024 )
Change subject: soc/intel/tigerlake: Refactor TCSS ASL to add _SB.PCI1 support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41024/3/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41024/3/src/soc/intel/tigerlake/acp...
PS3, Line 507: PCI1
So we're just repeating the same code but changing the path? Also, if segment groups are > 1 why are we assuming the device is living on segment 1. What if it's segment 2?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2935af79d8589a60f3c4e5a0b585f5b6dd19a32
Gerrit-Change-Number: 41024
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 05:04:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment