Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 1: # Padmelon board
file needs to be reference from other *. […]
From an index.md?
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 16: * One soldered down SPI flash with dediprog header
please provide a picture and description where to find the header. […]
Already did, but picture will be replaced by a new one.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
do you own the copyright on it? which license was it published under?
Picture will be replaced by one I myself will take.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 26: dediprog is protected from harm (even if still connected to the header) because the mux will float
limit to 80 chars per line
Will do.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 31: +---------------------+--------------------+
all tables needs to be embedded in ```eval_rst
will do.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 40: | In circuit flashing | no, use dediprog |
you desolder it every time you want to flash?
No, there's a header. The text (both sides) will be replaced with something more obvious.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 59: padmelon
please use proper markdown to include pictures
Will do.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... PS3, Line 14: specification<sup>1</sup>. coreboot relies on util/amdfwtool to build
that's not markdown
Will remove it.