Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45274 )
Change subject: lib/fmap: add ENV_SMM check to setup_preram_cache
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45274/5/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/45274/5/src/lib/fmap.c@50
PS5, Line 50: ENV_SMM
Would defining a new symbol ENV_STAGE_NO_FMAP_CACHE be a good idea?
Potentially, but it would only be for this case. The ROMSTAGE_OR_BEFORE check wants to spit out a warning. Let's see if such a thing becomes a necessity?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a4c199c42ee556187d6c4277e8793a36e4d493b
Gerrit-Change-Number: 45274
Gerrit-PatchSet: 5
Gerrit-Owner: Josie Nordrum
josienordrum@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Sep 2020 16:01:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment